linux-kernel - Re: [PATCH v4 2/3] KVM: nVMX: Validate the IA32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANRm+CyPweGvn-4Vt9JW9=HwkZnGoOySL7Jnaj+sVzATrBkWTA@mail.gmail.com>
Date:   Mon, 6 Nov 2017 09:32:13 +0800
From:   Wanpeng Li <kernellwp@...il.com>
To:     Jim Mattson <jmattson@...gle.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kvm list <kvm@...r.kernel.org>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Wanpeng Li <wanpeng.li@...mail.com>
Subject: Re: [PATCH v4 2/3] KVM: nVMX: Validate the IA32_BNDCFGS on nested VM-entry

2017-11-04 1:52 GMT+08:00 Jim Mattson <jmattson@...gle.com>:
> On Thu, Nov 2, 2017 at 5:35 PM, Wanpeng Li <kernellwp@...il.com> wrote:
>> From: Wanpeng Li <wanpeng.li@...mail.com>
>>
>> According to the SDM, if the "load IA32_BNDCFGS" VM-entry controls is 1, the
>> following checks are performed on the field for the IA32_BNDCFGS MSR:
>>  - Bits reserved in the IA32_BNDCFGS MSR must be 0.
>>  - The linear address in bits 63:12 must be canonical.
>>
>> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
>> Cc: Paolo Bonzini <pbonzini@...hat.com>
>> Cc: Radim Krčmář <rkrcmar@...hat.com>
>> Cc: Jim Mattson <jmattson@...gle.com>
>> Signed-off-by: Wanpeng Li <wanpeng.li@...mail.com>
>> ---
>> v3 -> v4:
>>  * simply condition
>>  * use && instead of nested "if"s
>>
>>  arch/x86/kvm/vmx.c | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/x86/kvm/vmx.c b/arch/x86/kvm/vmx.c
>> index e6c8ffa..6cf3972 100644
>> --- a/arch/x86/kvm/vmx.c
>> +++ b/arch/x86/kvm/vmx.c
>> @@ -10805,6 +10805,11 @@ static int check_vmentry_postreqs(struct kvm_vcpu *vcpu, struct vmcs12 *vmcs12,
>>                         return 1;
>>         }
>>
>> +       if (kvm_mpx_supported() &&
>
> I think you kept the wrong conjunct from the previous version. Drop
> kvm_mpx_supported() and restore the test for
> (vmcs12->vm_entry_controls & VM_ENTRY_LOAD_BNDCFGS).

Yeah, I misunderstand the English.

Regards,
Wanpeng Li