linux-kernel - Re: [PATCH] backlight: ili922x: remove redundant variable len

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2017 11:36:01 +0000
From:   Daniel Thompson <daniel.thompson@...aro.org>
To:     Colin King <colin.king@...onical.com>,
        Lee Jones <lee.jones@...aro.org>,
        Jingoo Han <jingoohan1@...il.com>,
        Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] backlight: ili922x: remove redundant variable len

On 05/11/17 11:53, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The variable len is assigned but never read, therefore it is redundant
> and can be removed. Cleans up clang warning:
> 
> drivers/video/backlight/ili922x.c:276:2: warning: Value stored to 'len'
> is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Acked-by: Daniel Thompson <daniel.thompson@...aro.org>

> ---
>   drivers/video/backlight/ili922x.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/video/backlight/ili922x.c b/drivers/video/backlight/ili922x.c
> index a9e9cef..2b6c6aa 100644
> --- a/drivers/video/backlight/ili922x.c
> +++ b/drivers/video/backlight/ili922x.c
> @@ -251,7 +251,7 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
>   	struct spi_transfer xfer_regindex, xfer_regvalue;
>   	unsigned char tbuf[CMD_BUFSIZE];
>   	unsigned char rbuf[CMD_BUFSIZE];
> -	int ret, len = 0;
> +	int ret;
>   
>   	memset(&xfer_regindex, 0, sizeof(struct spi_transfer));
>   	memset(&xfer_regvalue, 0, sizeof(struct spi_transfer));
> @@ -273,7 +273,6 @@ static int ili922x_write(struct spi_device *spi, u8 reg, u16 value)
>   	ret = spi_sync(spi, &msg);
>   
>   	spi_message_init(&msg);
> -	len = 0;
>   	tbuf[0] = set_tx_byte(START_BYTE(ili922x_id, START_RS_REG,
>   					 START_RW_WRITE));
>   	tbuf[1] = set_tx_byte((value & 0xFF00) >> 8);
>