linux-kernel - Re: [PATCH] freezer: Fix typo in commnent to function freezable_schedule

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171106113848.GG24863@amd>
Date:   Mon, 6 Nov 2017 12:38:48 +0100
From:   Pavel Machek <pavel@....cz>
To:     Himanshu Jha <himanshujha199640@...il.com>
Cc:     rjw@...ysocki.net, len.brown@...el.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, mcgrof@...nel.org
Subject: Re: [PATCH] freezer: Fix typo in commnent to function
 freezable_schedule_timeout()

On Mon 2017-11-06 16:57:09, Himanshu Jha wrote:
> On Sat, Nov 04, 2017 at 11:02:56PM +0100, Pavel Machek wrote:
> > On Sun 2017-11-05 03:27:32, Himanshu Jha wrote:
> > > Signed-off-by: Himanshu Jha <himanshujha199640@...il.com>
> > 
> > ACK.
> > 
> > But note you have typo in the subject ;-).
> 
> Oops!
> Do I need to send v2 with correct subject ?

I don't think that's required. I expect rjw will pick it up, maybe
fixing the subject.
									Pavel

> > Plus this kind of bug is usually called thinko.
> > 								Pavel
> > 
> > 
> > > diff --git a/include/linux/freezer.h b/include/linux/freezer.h
> > > index 3995df1..21f5aa0 100644
> > > --- a/include/linux/freezer.h
> > > +++ b/include/linux/freezer.h
> > > @@ -182,7 +182,7 @@ static inline void freezable_schedule_unsafe(void)
> > >  }
> > >  
> > >  /*
> > > - * Like freezable_schedule_timeout(), but should not block the freezer.  Do not
> > > + * Like schedule_timeout(), but should not block the freezer.  Do not
> > >   * call this with locks held.
> > >   */
> > >  static inline long freezable_schedule_timeout(long timeout)
> > 
> > -- 
> > (english) http://www.livejournal.com/~pavelmachek
> > (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
> 
> Thanks
> Himanshu Jha

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Download attachment "signature.asc" of type "application/pgp-signature" (182 bytes)