linux-kernel - Re: [PATCH net-next 4/6] net: hns3: add support for set_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f3846c6-0725-2cae-b1e6-f4519234331a@huawei.com>
Date:   Mon, 6 Nov 2017 10:28:58 +0800
From:   "lipeng (Y)" <lipeng321@...wei.com>
To:     Florian Fainelli <f.fainelli@...il.com>, <davem@...emloft.net>
CC:     <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linuxarm@...wei.com>, <salil.mehta@...wei.com>
Subject: Re: [PATCH net-next 4/6] net: hns3: add support for
 set_link_ksettings



On 2017/11/4 3:52, Florian Fainelli wrote:
> On 11/02/2017 09:18 PM, Lipeng wrote:
>> From: Fuyun Liang <liangfuyun1@...wei.com>
>>
>> This patch adds set_link_ksettings support for ethtool cmd.
>>
>> Signed-off-by: Fuyun Liang <liangfuyun1@...wei.com>
>> Signed-off-by: Lipeng <lipeng321@...wei.com>
>> ---
>>   drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> index c7b8ebd..7fe193b 100644
>> --- a/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> +++ b/drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c
>> @@ -653,6 +653,16 @@ static int hns3_get_link_ksettings(struct net_device *netdev,
>>   	return 0;
>>   }
>>   
>> +static int hns3_set_link_ksettings(struct net_device *netdev,
>> +				   const struct ethtool_link_ksettings *cmd)
>> +{
>> +	/* Only support ksettings_set for netdev with phy attached for now */
>> +	if (netdev->phydev)
>> +		return phy_ethtool_ksettings_set(netdev->phydev, cmd);
>> +
>> +	return -EOPNOTSUPP;
> Consider using phy_ethtool_get_link_ksettings() which already checks for
> netdev->phydev.
agree, Thanks for your comment.

as this patch has been applied to  net-next, we will push another 
cleanup patch.