linux-kernel - Re: [PATCH] tty: fix tty_ldisc_receive

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 6 Nov 2017 14:39:44 +0100
From:   Sebastian Reichel <sre@...nel.org>
To:     Johan Hovold <johan@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-kernel@...r.kernel.org,
        linux-serial@...r.kernel.org
Subject: Re: [PATCH] tty: fix tty_ldisc_receive_buf() documentation

Hi,

On Fri, Nov 03, 2017 at 03:18:05PM +0100, Johan Hovold wrote:
> The tty_ldisc_receive_buf() helper returns the number of bytes
> processed so drop the bogus "not" from the kernel doc comment.
> 
> Fixes: 8d082cd300ab ("tty: Unify receive_buf() code paths")
> Signed-off-by: Johan Hovold <johan@...nel.org>
> ---

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

-- Sebastian

>  drivers/tty/tty_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/tty_buffer.c b/drivers/tty/tty_buffer.c
> index f8eba1c5412f..677fa99b7747 100644
> --- a/drivers/tty/tty_buffer.c
> +++ b/drivers/tty/tty_buffer.c
> @@ -446,7 +446,7 @@ EXPORT_SYMBOL_GPL(tty_prepare_flip_string);
>   *	Callers other than flush_to_ldisc() need to exclude the kworker
>   *	from concurrent use of the line discipline, see paste_selection().
>   *
> - *	Returns the number of bytes not processed
> + *	Returns the number of bytes processed
>   */
>  int tty_ldisc_receive_buf(struct tty_ldisc *ld, const unsigned char *p,
>  			  char *f, int count)
> -- 
> 2.15.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)