linux-kernel - [PATCH] clocksource: timer-of: drop __init annotations in timer_*

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon,  6 Nov 2017 14:48:36 +0000
From:   Sudeep Holla <sudeep.holla@....com>
To:     linux-kernel@...r.kernel.org
Cc:     Sudeep Holla <sudeep.holla@....com>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: [PATCH] clocksource: timer-of: drop __init annotations in timer_*_exit functions

timer_{base,clk,irq}_exit functions have __init annotations. Commit
f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
added timer_of_exit to undo what has been done by the timer_of_init()
function, which means we need to drop __init to use timer_*_exit
functions.

It also generates the build time warning:
"WARNING: vmlinux.o: Section mismatch in reference from the
 function timer_of_exit() to the variable .init.text:$x
 The function timer_of_exit() references the variable __init $x.
 This is often because timer_of_exit lacks a __init annotation or the
 annotation of $x is wrong."

This patch fixes the above build warning.

Fixes: f48729a999ee ("clocksource/drivers/timer-of: Add timer_of_exit function")
Cc: Daniel Lezcano <daniel.lezcano@...aro.org>
Cc: Thomas Gleixner <tglx@...utronix.de>
Signed-off-by: Sudeep Holla <sudeep.holla@....com>
---
 drivers/clocksource/timer-of.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/clocksource/timer-of.c b/drivers/clocksource/timer-of.c
index 7c64a5c1bfc1..701b476ccc7c 100644
--- a/drivers/clocksource/timer-of.c
+++ b/drivers/clocksource/timer-of.c
@@ -24,7 +24,7 @@
 
 #include "timer-of.h"
 
-static __init void timer_irq_exit(struct of_timer_irq *of_irq)
+static void timer_irq_exit(struct of_timer_irq *of_irq)
 {
 	struct timer_of *to = container_of(of_irq, struct timer_of, of_irq);
 
@@ -72,7 +72,7 @@ static __init int timer_irq_init(struct device_node *np,
 	return 0;
 }
 
-static __init void timer_clk_exit(struct of_timer_clk *of_clk)
+static void timer_clk_exit(struct of_timer_clk *of_clk)
 {
 	of_clk->rate = 0;
 	clk_disable_unprepare(of_clk->clk);
@@ -116,7 +116,7 @@ static __init int timer_clk_init(struct device_node *np,
 	goto out;
 }
 
-static __init void timer_base_exit(struct of_timer_base *of_base)
+static void timer_base_exit(struct of_timer_base *of_base)
 {
 	iounmap(of_base->base);
 }
-- 
2.7.4