linux-kernel - Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and ldlinux.c32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106030058.GB1464@intel.com>
Date:   Mon, 6 Nov 2017 11:00:59 +0800
From:   "Du, Changbin" <changbin.du@...el.com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     changbin.du@...el.com, hpa@...or.com, tglx@...utronix.de,
        mingo@...hat.com, x86@...nel.org, linux-kernel@...r.kernel.org,
        yamada.masahiro@...ionext.com
Subject: Re: [PATCH 2/4] x86, build: Add new paths for isolinux.bin and
 ldlinux.c32

Hi Ingo,
On Sun, Nov 05, 2017 at 10:33:53AM +0100, Ingo Molnar wrote:
> 
> * changbin.du@...el.com <changbin.du@...el.com> wrote:
> 
> > From: Changbin Du <changbin.du@...el.com>
> > 
> > Recently I failed to build isoimage target, because the path of isolinux.bin
> > changed to /usr/xxx/ISOLINUX/isolinux.bin, as well as ldlinux.c32 which
> > changed to /usr/xxx/syslinux/modules/bios/ldlinux.c32.
> > 
> > This patch has a improvement of the file search:
> >   - Show a error message instead of silent fail.
> >   - Add above new paths.
> 
> How about:
> 
>   This patch improves the file search logic:
>     - Show an error message instead of failing silently
>     - Add the new paths listed above.
> 
> 
> > +		if [ $i = end -a -z "$isolinux" ] ; then
> > +			echo 'Need isolinux.bin, please install syslinux/isolinux'
> 
> How about:
> 
> 			echo 'Need an isolinux.bin file, please install syslinux/isolinux'
>
The new description is much better, will update. Thanks.

> Thanks,
> 
> 	Ingo

-- 
Thanks,
Changbin Du

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)