linux-kernel - Re: [Part2 PATCH v7 33/38] KVM: SVM: Add support for SEV DEBUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7dcacb08-2a08-c902-691c-a454a3737aca@amd.com>
Date:   Mon, 6 Nov 2017 10:38:00 -0600
From:   Brijesh Singh <brijesh.singh@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     brijesh.singh@....com, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org, Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Radim Krčmář <rkrcmar@...hat.com>,
        Joerg Roedel <joro@...tes.org>,
        Tom Lendacky <thomas.lendacky@....com>, x86@...nel.org
Subject: Re: [Part2 PATCH v7 33/38] KVM: SVM: Add support for SEV
 DEBUG_ENCRYPT command



On 11/06/2017 05:31 AM, Borislav Petkov wrote:
...

>> -		ret = sev_dbg_decrypt_user(kvm,
>> -					   __sme_page_pa(src_p[0]) + s_off,
>> -					   dst_vaddr,
>> -					   __sme_page_pa(dst_p[0]) + d_off,
>> -					   len, &argp->error);
>> +		if (dec)
>> +			ret = sev_dbg_decrypt_user(kvm,
>> +						   __sme_page_pa(src_p[0]) + s_off,
>> +						   dst_vaddr,
>> +						   __sme_page_pa(dst_p[0]) + d_off,
>> +						   len, &argp->error);
>> +		else
>> +			ret = __sev_dbg_encrypt_user(kvm,
>> +						     __sme_page_pa(src_p[0]) + s_off,
>> +						     vaddr,
>> +						     __sme_page_pa(dst_p[0]) + d_off,
>> +						     dst_vaddr,
>> +						     len, &argp->error);
> 
> sev_dbg_decrypt_user but __sev_dbg_encrypt_user, with the "__" ??
> 

yes they both should be "__", I will overlooked it and will fix in next rev.