linux-kernel - Re: [PATCH] sysctl: add register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jKXFHQ2Er7EnjV+8MMVjiJLVTiyGK62OAaHbzDQu=CtbA@mail.gmail.com>
Date:   Mon, 6 Nov 2017 08:51:37 -0800
From:   Kees Cook <keescook@...omium.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will.deacon@....com>,
        "Luis R. Rodriguez" <mcgrof@...nel.org>,
        Alex Bennée <alex.bennee@...aro.org>,
        Dave Martin <Dave.Martin@....com>,
        "Eric W. Biederman" <ebiederm@...ssion.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] sysctl: add register_sysctl() dummy helper

On Mon, Nov 6, 2017 at 5:36 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The register_sysctl() function has been around for five years with commit
> fea478d4101a ("sysctl: Add register_sysctl for normal sysctl users")
> but now that arm64 started using it, I ran into a compile error:
>
> arch/arm64/kernel/armv8_deprecated.c: In function 'register_insn_emulation_sysctl':
> arch/arm64/kernel/armv8_deprecated.c:257:2: error: implicit declaration of function 'register_sysctl'
>
> This adds a inline function like we already have for register_sysctl_paths()
> and register_sysctl_table().
>
> Fixes: 38b9aeb32fa7 ("arm64: Port deprecated instruction emulation to new sysctl interface")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
> This should probably get merged through the arm64 tree to avoid
> bisection problems.

Sure, that sounds fine.

Acked-by: Kees Cook <keescook@...omium.org>

Thanks!

-Kees

> ---
>  include/linux/sysctl.h | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/include/linux/sysctl.h b/include/linux/sysctl.h
> index fabe15e51c56..992bc9948232 100644
> --- a/include/linux/sysctl.h
> +++ b/include/linux/sysctl.h
> @@ -216,6 +216,11 @@ static inline struct ctl_table_header *register_sysctl_paths(
>         return NULL;
>  }
>
> +static inline struct ctl_table_header *register_sysctl(const char *path, struct ctl_table *table)
> +{
> +       return NULL;
> +}
> +
>  static inline void unregister_sysctl_table(struct ctl_table_header * table)
>  {
>  }
> --
> 2.9.0
>



-- 
Kees Cook
Pixel Security