linux-kernel - Re: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new revision

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b24eb03-1f0e-ec65-b12b-65036ef7addc@codeaurora.org>
Date:   Mon, 6 Nov 2017 13:15:43 -0500
From:   Sinan Kaya <okaya@...eaurora.org>
To:     Robin Murphy <robin.murphy@....com>, dmaengine@...r.kernel.org,
        timur@...eaurora.org
Cc:     linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/3] dmaengine: qcom_hidma: add support for the new
 revision

On 11/6/2017 1:03 PM, Robin Murphy wrote:
>>  #ifdef CONFIG_ACPI
>>  		ret = strcmp(acpi_device_hid(adev), "QCOM8062");
>> +		if (ret)
>> +			ret = strcmp(acpi_device_hid(adev), "QCOM8063");
> This string-juggling looks to have already hit the point at which it
> doesn't scale well - it would be a lot nicer to make use of
> of_device_get_match_data() and the ACPI equivalent to abstract the
> version-specific data appropriately.

Sure, let me do some research.

-- 
Sinan Kaya
Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project.