linux-kernel - Re: [PATCH v4] i2c: aspeed: Deassert reset in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106182318.xk2rkz7vv2p3sqso@ninjato>
Date:   Mon, 6 Nov 2017 19:23:18 +0100
From:   Wolfram Sang <wsa@...-dreams.de>
To:     Joel Stanley <joel@....id.au>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Philipp Zabel <philipp.zabel@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        Andrew Jeffery <andrew@...id.au>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4] i2c: aspeed: Deassert reset in probe

On Wed, Nov 01, 2017 at 10:53:30AM +1030, Joel Stanley wrote:
> In order to use i2c from a cold boot, the i2c peripheral must be taken
> out of reset. We request a shared reset controller each time a bus
> driver is loaded, as the reset is shared between the 14 i2c buses.
> 
> On remove the reset is asserted, which only touches the hardware once
> the last i2c bus is removed.
> 
> The reset is required as the I2C buses will not work without releasing
> the reset. Previously the driver only worked with out of tree hacks
> that released this reset before the driver was loaded. Update the
> device tree bindings to reflect this.
> 
> Signed-off-by: Joel Stanley <joel@....id.au>

Applied to for-next, thanks and thanks for the ack, Rob!


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)