linux-kernel - Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB6PR04MB29992D82295832B25FC3912D86500@DB6PR04MB2999.eurprd04.prod.outlook.com>
Date:   Mon, 6 Nov 2017 19:40:06 +0000
From:   Roy Pledge <roy.pledge@....com>
To:     Laurentiu Tudor <laurentiu.tudor@....com>,
        Greg KH <gregkh@...uxfoundation.org>
CC:     "devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
        "stuyoder@...il.com" <stuyoder@...il.com>,
        "arnd@...db.de" <arnd@...db.de>,
        "marc.zyngier@....com" <marc.zyngier@....com>,
        Stuart Yoder <stuart.yoder@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "agraf@...e.de" <agraf@...e.de>,
        "Catalin Horghidan" <catalin.horghidan@....com>,
        Ioana Ciornei <ioana.ciornei@....com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Leo Li <leoyang.li@....com>,
        "Bharat Bhushan" <bharat.bhushan@....com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        Jason Cooper <jason@...edaemon.net>
Subject: Re: [PATCH v2] staging: fsl-mc: move bus driver out of staging

>> struct dpaa2_io {
>>           atomic_t refs;
>>
>> That's a kref, please use it instead of trying to roll your own.
>>
>> And even for this, your locking is not correct (i.e. you do not have
>> any), that needs to be fixed so that teardown works correctly.
> 
> I think we can drop this refcount altogether as it's not used. Roy, any
> comment on this?
> 

Yes I think this refcount can be removed.  I'll make a note for when the 
DPIO is moving out of staging but that isn't part of this patchset. 
There are other cleanups needed in DPIO as well. I've been holding off 
on pushing patches for that until the bus driver gets moved to try to 
avoid complex patch dependencies and merge conflict confusion.