linux-kernel - Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0CA81505-0EFB-4F30-A0B1-E021953741D1@cavium.com>
Date:   Mon, 6 Nov 2017 19:58:45 +0000
From:   "Madhani, Himanshu" <Himanshu.Madhani@...ium.com>
To:     Bart Van Assche <bart.vanassche@....com>
CC:     "keescook@...omium.org" <keescook@...omium.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        Dept-Eng QLA2xxx Upstream <qla2xxx-upstream@...ium.com>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>
Subject: Re: [PATCH 0/4] scsi: qla2xxx: Convert timers to use timer_setup()

Hi Bart, 

> On Nov 5, 2017, at 4:18 PM, Bart Van Assche <bart.vanassche@....com> wrote:
> 
> On Wed, 2017-11-01 at 19:18 +0000, Madhani, Himanshu wrote:
>> Hi Kees, 
>> 
>>> On Nov 1, 2017, at 11:46 AM, Kees Cook <keescook@...omium.org> wrote:
>>> 
>>> On Tue, Oct 31, 2017 at 12:13 PM, Kees Cook <keescook@...omium.org> wrote:
>>>> This breaks out the logical steps to convert the qla2xxx timers:
>>>> 
>>>> 1) init_timer() -> setup_timer()
>>>> 2) refactor qla2x00_start_timer() to not pass callback as argument
>>>> 3) qla2x00_timer() to use timer_setup()
>>>> 4) qla2x00_sp_timeout() to use timer_setup()
>>>> 
>>>> The resulting diff is identical to the patch that appears to lock up
>>>> the driver. This should help identify which step causes this behavior.
>>> 
>>> Hi, just curious if there's been any progress on debugging the issue
>>> you saw with this series?
>> 
>> Sorry for delay. I will test this series later today and post update. 
> 
> Hello Himanshu and Kees,
> 
> The qla2xxx driver does not crash if apply these four patches on kernel
> v4.14-rc8 and load the qla2xxx driver on my test setup. Point-to-point
> mode seems broken again but I don't think that's related to this patch
> series.
> 
> Bart.

What kind of errors you are seeing with Point-to-point mode. I’ll look at those
and will submit fixes for it along with the other issues you have raised earlier.

Kees, 

I’ll get back to validating the series again now. Sorry for delay. 

Thanks,
- Himanshu