linux-kernel - Re: [PATCH v2 1/1] at24: support eeproms that do not roll over page reads.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171106202634.tuwdi76w6bmaqf4y@rob-hp-laptop>
Date:   Mon, 6 Nov 2017 14:26:34 -0600
From:   Rob Herring <robh@...nel.org>
To:     Sven Van Asbroeck <svendev@...x.com>
Cc:     mark.rutland@....com, wsa@...-dreams.de, nsekhar@...com,
        david@...hnology.com, javier@...hile0.org, brgl@...ev.pl,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-i2c@...r.kernel.org
Subject: Re: [PATCH v2 1/1] at24: support eeproms that do not roll over page
 reads.

On Wed, Nov 01, 2017 at 09:44:03AM -0400, Sven Van Asbroeck wrote:
> Some eeproms in the at24 family do not roll over page reads,
> e.g. the Microchip 24AA16/24LC16B. On those eeproms, reads
> that straddle block boundaries will not work correctly.
> 
> Solution:
> Implement read rollover in the driver. To enable it, add the
> AT24_FLAG_NO_RDROL flag to the eeprom entry in the
> device_id table, or add 'no-read-rollover' to the eeprom
> devicetree entry.
> 
> Signed-off-by: Sven Van Asbroeck <svendev@...x.com>
> ---
>  .../devicetree/bindings/eeprom/eeprom.txt          |  5 +++

Acked-by: Rob Herring <robh@...nel.org>

>  drivers/misc/eeprom/at24.c                         | 47 +++++++++++-----------
>  include/linux/platform_data/at24.h                 |  1 +
>  3 files changed, 29 insertions(+), 24 deletions(-)