linux-kernel - Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in ocrdma_mbx_dealloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 18:28:04 +0200
From:   Leon Romanovsky <leon@...nel.org>
To:     "Gustavo A. R. Silva" <garsilva@...eddedor.com>
Cc:     Selvin Xavier <selvin.xavier@...adcom.com>,
        Devesh Sharma <devesh.sharma@...adcom.com>,
        Doug Ledford <dledford@...hat.com>,
        Yuval Shaia <yuval.shaia@...cle.com>,
        linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] IB/ocrdma_hw: remove unnecessary code in
 ocrdma_mbx_dealloc_lkey

On Tue, Nov 07, 2017 at 08:56:37AM -0600, Gustavo A. R. Silva wrote:
>
> Quoting Leon Romanovsky <leon@...nel.org>:
>
> > On Tue, Nov 07, 2017 at 08:45:17AM -0600, Gustavo A. R. Silva wrote:
> > > Check on return value and goto label mbx_err are unnecessary.
> > >
> > > Addresses-Coverity-ID: 1268780
> > > Signed-off-by: Gustavo A. R. Silva <garsilva@...eddedor.com>
> > > Reviewed-by: Yuval Shaia <yuval.shaia@...cle.com>
> > > ---
> > > Changes in v2:
> > >  Remove assignment from "int status = -ENOMEM" as suggested by Leon
> > > Romanovsky.
> > >
> > >  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ++----
> > >  1 file changed, 2 insertions(+), 4 deletions(-)
> >
> > Please use git send-email to send patches and not reply to the conversation.
> >
>
> I'm using mutt.
> What would be the advantage of using git send-email in this case?

New mail headers, so it won't appear as Reply-To and will be presented
correctly in mutt's threaded mode.

You can do it with mutt too.

>
> > Thanks,
> > Reviewed-by: Leon Romanovsky <leonro@...lanox.com>
>
> Thank you
> --
> Gustavo A. R. Silva
>
>
>
>
>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)