linux-kernel - Re: [PATCH] perf/core: fast breakpoint modification via _IOC_MODIFY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171107172429.GG5320@tassilo.jf.intel.com>
Date:   Tue, 7 Nov 2017 09:24:29 -0800
From:   Andi Kleen <ak@...ux.intel.com>
To:     Milind Chabbi <chabbi.milind@...il.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Jiri Olsa <jolsa@...hat.com>, Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Michael Ellerman <mpe@...erman.id.au>,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Jin Yao <yao.jin@...ux.intel.com>,
        Kan Liang <kan.liang@...el.com>,
        Sukadev Bhattiprolu <sukadev@...ux.vnet.ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf/core: fast breakpoint modification via
 _IOC_MODIFY_BREAKPOINT.

On Tue, Nov 07, 2017 at 07:43:35AM -0800, Milind Chabbi wrote:
> Peter,
> 
> Generic update perf_event_attr interface is noble but impractical.
> It will cause a validation nightmare.
> Many of the behaviors or choices will become hard to reason.

I don't think you would necessarily need to support modifying
all of this. Just define a general interface that could be used
to modify these things, but right now it would be only
implemented for the special case of breakpoints.

Your ioctl is very near it anyways, just need to change
the name and do more sanity checking on the input values.

-Andi