linux-kernel - RE: [PATCH] aacraid: use timespec64 instead of timeval

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <423FD6710FB8FB4F8728F93591889F9A6941C525@avsrvexchmbx2.microsemi.net>
Date:   Tue, 7 Nov 2017 17:40:13 +0000
From:   Dave Carroll <david.carroll@...rosemi.com>
To:     Arnd Bergmann <arnd@...db.de>,
        dl-esc-Aacraid Linux Driver <aacraid@...rosemi.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
CC:     Raghava Aditya Renukunta <RaghavaAditya.Renukunta@...rosemi.com>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Hannes Reinecke <hare@...e.de>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] aacraid: use timespec64 instead of timeval

> 
> aacraid passes the current time to the firmware in one of two ways,
> either as year/month/day/... or as 32-bit unsigned seconds.
> 
> The first one is broken on 32-bit architectures as it cannot
> go past year 2038. Using timespec64 here makes it behave properly
> on both 32-bit and 64-bit architectures, and avoids relying
> on signed integer overflow to pass times into the second interface.
> 
> The interface used in aac_send_hosttime() however is still
> problematic in year 2106 when 32-bit seconds overflow. Hopefully
> we don't have to worry about aacraid by that time.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Reviewed-by: Dave Carroll <david.carroll@...rosemi.com>