linux-kernel - Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in pci_register_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171107002501.GD9538@bhelgaas-glaptop.roam.corp.google.com>
Date:   Mon, 6 Nov 2017 18:25:01 -0600
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Gabriele Paoloni <gabriele.paoloni@...wei.com>
Cc:     catalin.marinas@....com, will.deacon@....com, robh+dt@...nel.org,
        frowand.list@...il.com, bhelgaas@...gle.com, rafael@...nel.org,
        arnd@...db.de, linux-arm-kernel@...ts.infradead.org,
        lorenzo.pieralisi@....com, mark.rutland@....com,
        brian.starkey@....com, olof@...om.net, benh@...nel.crashing.org,
        linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org,
        linuxarm@...wei.com, linux-pci@...r.kernel.org, minyard@....org,
        john.garry@...wei.com, xuwei5@...ilicon.com
Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in
 pci_register_io_range()

On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote:
> From: gabriele paoloni <gabriele.paoloni@...wei.com>
> 
> Currently pci_register_io_range() has only one definition;
> therefore there is no use of the __weak attribute.
> 
> Signed-off-by: Gabriele Paoloni <gabriele.paoloni@...wei.com>
> Acked-by: Bjorn Helgaas <helgaas@...nel.org>

Also, I normally use this (Google address instead of kernel.org):

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

(Also affects your other PCI patches.)

> ---
>  drivers/pci/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index af0cc34..eee967c 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock);
>   * Record the PCI IO range (expressed as CPU physical address + size).
>   * Return a negative value if an error has occured, zero otherwise
>   */
> -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t size)
> +int pci_register_io_range(phys_addr_t addr, resource_size_t size)
>  {
>  	int err = 0;
>  
> -- 
> 2.7.4
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html