linux-kernel - [PATCH] w1: remove redundant assignments to search_bit and last

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20171107184914.7561-1-colin.king@canonical.com>
Date:   Tue,  7 Nov 2017 18:49:14 +0000
From:   Colin King <colin.king@...onical.com>
To:     Evgeniy Polyakov <zbr@...emap.net>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] w1: remove redundant assignments to search_bit and last_rn

From: Colin Ian King <colin.king@...onical.com>

Variables search_bit and last_rn are assigned values before a while-loop
however these initial values are never read (as they are overwritten
inside the loop). Thus these initial assignments are redundant and can
be removed. Cleans up clang warnings:

drivers/w1/w1.c:967:2: warning: Value stored to 'search_bit' is never
read
drivers/w1/w1.c:969:2: warning: Value stored to 'last_rn' is never read

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 drivers/w1/w1.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 0c2a5a8327bd..c29f6c5dda3c 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -964,9 +964,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb
 	int search_bit, desc_bit;
 	u8  triplet_ret = 0;
 
-	search_bit = 0;
 	rn = dev->search_id;
-	last_rn = 0;
 	last_device = 0;
 	last_zero = -1;
 
-- 
2.14.1