linux-kernel - [PATCH 3.16 237/294] be2iscsi: Fix bogus WARN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lsq.1510009382.190423207@decadent.org.uk>
Date:   Mon, 06 Nov 2017 23:03:02 +0000
From:   Ben Hutchings <ben@...adent.org.uk>
To:     linux-kernel@...r.kernel.org, stable@...r.kernel.org
CC:     akpm@...ux-foundation.org, "Arnd Bergmann" <arnd@...db.de>,
        "Joel Stanley" <joel@....id.au>,
        "Manoj Kumar" <manoj@...ux.vnet.ibm.com>,
        "Jayamohan Kallickal" <jayamohan.kallickal@...gotech.com>,
        "James E.J. Bottomley" <JBottomley@...n.com>,
        "Tim Gardner" <tim.gardner@...onical.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "Minh Tran" <minh.tran@...gotech.com>,
        "John Soni Jose" <sony.john-n@...gotech.com>
Subject: [PATCH 3.16 237/294] be2iscsi: Fix bogus WARN_ON length check

3.16.50-rc1 review patch.  If anyone has any objections, please let me know.

------------------

From: Tim Gardner <tim.gardner@...onical.com>

commit dd29dae00d39186890a5eaa2fe4ad8768bfd41a9 upstream.

drivers/scsi/be2iscsi/be_main.c: In function 'be_sgl_create_contiguous':
drivers/scsi/be2iscsi/be_main.c:3187:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
  WARN_ON(!length > 0);

gcc version 5.2.1

Signed-off-by: Tim Gardner <tim.gardner@...onical.com>
Cc: Jayamohan Kallickal <jayamohan.kallickal@...gotech.com>
Cc: Minh Tran <minh.tran@...gotech.com>
Cc: John Soni Jose <sony.john-n@...gotech.com>
Cc: "James E.J. Bottomley" <JBottomley@...n.com>
Reported-by: Joel Stanley <joel@....id.au>
Reviewed-by: Manoj Kumar <manoj@...ux.vnet.ibm.com>
Signed-off-by: Martin K. Petersen <martin.petersen@...cle.com>
Signed-off-by: Arnd Bergmann <arnd@...db.de>
Signed-off-by: Ben Hutchings <ben@...adent.org.uk>
---
 drivers/scsi/be2iscsi/be_main.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3152,7 +3152,7 @@ be_sgl_create_contiguous(void *virtual_a
 {
 	WARN_ON(!virtual_address);
 	WARN_ON(!physical_address);
-	WARN_ON(!length > 0);
+	WARN_ON(!length);
 	WARN_ON(!sgl);
 
 	sgl->va = virtual_address;