linux-kernel - Re: [tip:x86/mm] mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171107011516.GA13514@arm.com>
Date:   Tue, 7 Nov 2017 01:15:17 +0000
From:   Will Deacon <will.deacon@....com>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Sudeep Holla <sudeep.holla@....com>,
        "Kirill A. Shutemov" <kirill@...temov.name>,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>, hpa@...or.com,
        Andrew Morton <akpm@...ux-foundation.org>, gorcunov@...nvz.org,
        Andy Lutomirski <luto@...capital.net>, bp@...e.de,
        open list <linux-kernel@...r.kernel.org>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        Catalin Marinas <catalin.marinas@....com>
Subject: Re: [tip:x86/mm] mm/sparsemem: Allocate mem_section at runtime for
 CONFIG_SPARSEMEM_EXTREME=y

On Mon, Nov 06, 2017 at 11:00:09AM -0800, Bjorn Andersson wrote:
> On Thu, Nov 2, 2017 at 7:12 AM, Kirill A. Shutemov
> <kirill.shutemov@...ux.intel.com> wrote:
> [..]
> > Could you try the patch below instead?
> >
> > From 4a9d843f9d939d958612b0079ebe5743f265e1e0 Mon Sep 17 00:00:00 2001
> > From: "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>
> > Date: Thu, 2 Nov 2017 17:02:29 +0300
> > Subject: [PATCH] mm, sparse: Fix boot on arm64
> >
> > Since 83e3c48729d9 ("mm/sparsemem: Allocate mem_section at runtime for
> > CONFIG_SPARSEMEM_EXTREME=y") we allocate mem_section dynamically in
> > sparse_memory_present_with_active_regions(). But some architectures, like
> > arm64, don't use the routine to initialize sparsemem.
> >
> > Let's move the initialization into memory_present() it should cover all
> > architectures.
> >
> > Signed-off-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> > Fixes: 83e3c48729d9 ("mm/sparsemem: Allocate mem_section at runtime for CONFIG_SPARSEMEM_EXTREME=y")
> 
> Will you send out this patch, or will someone pick it up from here?
> 
> As with the other arm64 boards this is the difference between
> linux-next (and presumably v4.15-rc1) booting or not on my Qualcomm
> boards.
> 
> Tested-by: Bjorn Andersson <bjorn.andersson@...aro.org>

Yes, please can somebody get this into -next asap? I can't take it via
arm64, since this code isn't present there.

If you need it:

Acked-by: Will Deacon <will.deacon@....com>

Will