linux-kernel - Re: [f2fs-dev] [PATCH] f2fs: keep scanning until enough free nids are acquired

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171107034034.GC92599@jaegeuk-macbookpro.roam.corp.google.com>
Date:   Mon, 6 Nov 2017 19:40:34 -0800
From:   Jaegeuk Kim <jaegeuk@...nel.org>
To:     Fan Li <fanofcode.li@...sung.com>
Cc:     'Chao Yu' <chao@...nel.org>, 'Chao Yu' <yuchao0@...wei.com>,
        linux-kernel@...r.kernel.org,
        linux-f2fs-devel@...ts.sourceforge.net
Subject: Re: [f2fs-dev] [PATCH] f2fs: keep scanning until enough free nids
 are acquired

Hi,

I merged this patch after fixing some broken format. Could you please check
your email configuration?

Thanks,

On 11/07, Fan Li wrote:
> In current version, after scan_free_nid_bits, the scan is over if nid_cnt[FREE_NID] != 0.
> In most cases, there are still free nids in the free list during the scan, and scan_free_nid_bits
> usually can't increase nid_cnt[FREE_NID].
> It causes that __build_free_nids is called many times without solving the shortage
> of the free nids. This patch fixes that.
> 
> Signed-off-by: Fan li <fanofcode.li@...sung.com>
> ---
>  fs/f2fs/node.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
> index 3d0d1be..5cef118 100644
> --- a/fs/f2fs/node.c
> +++ b/fs/f2fs/node.c
> @@ -2010,7 +2010,7 @@ static void __build_free_nids(struct f2fs_sb_info *sbi, bool sync, bool mount)
>                 /* try to find free nids in free_nid_bitmap */
>                 scan_free_nid_bits(sbi);
> 
> -               if (nm_i->nid_cnt[FREE_NID])
> +               if (nm_i->nid_cnt[FREE_NID] >= NAT_ENTRY_PER_BLOCK)
>                         return;
>         }
> 
> --
> 2.7.4