linux-kernel - Re: [PATCH] mpt3sas: fix dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <yq17ev23fd7.fsf@oracle.com>
Date:   Mon, 06 Nov 2017 23:03:00 -0500
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Sathya Prakash <sathya.prakash@...adcom.com>,
        Chaitra P B <chaitra.basappa@...adcom.com>,
        Suganath Prabu Subramani 
        <suganath-prabu.subramani@...adcom.com>,
        "James E.J. Bottomley" <jejb@...ux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        Tomas Henzl <thenzl@...hat.com>,
        Sreekanth Reddy <sreekanth.reddy@...adcom.com>,
        Hannes Reinecke <hare@...e.de>,
        Romain Perier <romain.perier@...labora.com>,
        James Bottomley <James.Bottomley@...senPartnership.com>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        MPT-FusionLinux.pdl@...adcom.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mpt3sas: fix dma_addr_t casts


Arnd,

> After taking a closer look, I found that the problem is that the new
> code mixes up pointers and dma_addr_t values unnecessarily.
>
> This changes it to use the correct types consistently, which lets us
> get rid of a lot of type casts in the process. I'm also renaming some
> variables to avoid confusion between physical and dma address spaces
> that are often distinct.

Nice work! Applied to 4.15/scsi-queue. Thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering