linux-kernel - Re: [PATCH v3 4/4] ARM64: dts: meson: drop "sana" clock from SARADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1042f0e2-1a13-af57-5057-6f97ff4c4aa2@amlogic.com>
Date:   Tue, 7 Nov 2017 13:49:26 +0800
From:   Yixun Lan <yixun.lan@...ogic.com>
To:     Kevin Hilman <khilman@...libre.com>, <devicetree@...r.kernel.org>,
        Martin Blumenstingl <martin.blumenstingl@...glemail.com>
CC:     <yixun.lan@...ogic.com>, Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Carlo Caione <carlo@...one.org>,
        Xingyu Chen <xingyu.chen@...ogic.com>,
        <linux-amlogic@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 4/4] ARM64: dts: meson: drop "sana" clock from SARADC

Hi

On 11/07/17 13:37, Yixun Lan wrote:
> From: Xingyu Chen <xingyu.chen@...ogic.com>
> 
> The SAR ADC modules doesn't require The "sana" clock.
> 
> Singed-off-by: Xingyu Chen <xingyu.chen@...ogic.com>
> Signed-off-by: Yixun Lan <yixun.lan@...ogic.com>
> ---
>  arch/arm/boot/dts/meson8.dtsi               | 5 ++---
>  arch/arm/boot/dts/meson8b.dtsi              | 5 ++---
>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 3 +--
>  arch/arm64/boot/dts/amlogic/meson-gxl.dtsi  | 3 +--
>  4 files changed, 6 insertions(+), 10 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/meson8.dtsi b/arch/arm/boot/dts/meson8.dtsi
> index b98d44fde6b6..f93d6cf6e094 100644
> --- a/arch/arm/boot/dts/meson8.dtsi
> +++ b/arch/arm/boot/dts/meson8.dtsi
> @@ -289,9 +289,8 @@
>  &saradc {
>  	compatible = "amlogic,meson8-saradc", "amlogic,meson-saradc";
>  	clocks = <&clkc CLKID_XTAL>,
> -		<&clkc CLKID_SAR_ADC>,
> -		<&clkc CLKID_SANA>;
> -	clock-names = "clkin", "core", "sana";
> +		<&clkc CLKID_SAR_ADC>;
> +	clock-names = "clkin", "core";
>  };
>  
>  &spifc {
> diff --git a/arch/arm/boot/dts/meson8b.dtsi b/arch/arm/boot/dts/meson8b.dtsi
> index bc278da7df0d..4aa444284f0c 100644
> --- a/arch/arm/boot/dts/meson8b.dtsi
> +++ b/arch/arm/boot/dts/meson8b.dtsi
> @@ -185,9 +185,8 @@
>  &saradc {
>  	compatible = "amlogic,meson8b-saradc", "amlogic,meson-saradc";
>  	clocks = <&clkc CLKID_XTAL>,
> -		<&clkc CLKID_SAR_ADC>,
> -		<&clkc CLKID_SANA>;
> -	clock-names = "clkin", "core", "sana";
> +		<&clkc CLKID_SAR_ADC>;
> +	clock-names = "clkin", "core";
>  };
>  
>  &uart_AO {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> index af834cdbba79..b77f2593cdc3 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
> @@ -686,10 +686,9 @@
>  	compatible = "amlogic,meson-gxbb-saradc", "amlogic,meson-saradc";
>  	clocks = <&xtal>,
>  		 <&clkc CLKID_SAR_ADC>,
> -		 <&clkc CLKID_SANA>,
>  		 <&clkc CLKID_SAR_ADC_CLK>,
>  		 <&clkc CLKID_SAR_ADC_SEL>;
> -	clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> +	clock-names = "clkin", "core", "adc_clk", "adc_sel";
>  };
>  
>  &sd_emmc_a {
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> index d8dd3298b15c..07805a3b4db0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
> @@ -628,10 +628,9 @@
>  	compatible = "amlogic,meson-gxl-saradc", "amlogic,meson-saradc";
>  	clocks = <&xtal>,
>  		 <&clkc CLKID_SAR_ADC>,
> -		 <&clkc CLKID_SANA>,
>  		 <&clkc CLKID_SAR_ADC_CLK>,
>  		 <&clkc CLKID_SAR_ADC_SEL>;
> -	clock-names = "clkin", "core", "sana", "adc_clk", "adc_sel";
> +	clock-names = "clkin", "core", "adc_clk", "adc_sel";
>  };
>  
>  &sd_emmc_a {
> 

sorry, please drop this particular 'patch [4/4]', I've actually send it
twice, others are good.