linux-kernel - Re: possible deadlock in generic_file_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACT4Y+bWot0Hw-z_dCY2fKpb1JSd9u_rzSqER+_Bwy3Lnd98uQ@mail.gmail.com>
Date:   Tue, 7 Nov 2017 09:18:01 +0100
From:   Dmitry Vyukov <dvyukov@...gle.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Byungchul Park <byungchul.park@....com>,
        Al Viro <viro@...iv.linux.org.uk>, Jan Kara <jack@...e.cz>,
        syzbot 
        <bot+f99f3a0db9007f4f4e32db54229a240c4fe57c15@...kaller.appspotmail.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Johannes Weiner <hannes@...xchg.org>, jlayton@...hat.com,
        LKML <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
        npiggin@...il.com, rgoldwyn@...e.com, ross.zwisler@...ux.intel.com,
        syzkaller-bugs@...glegroups.com, Ingo Molnar <mingo@...hat.com>,
        kernel-team@....com
Subject: Re: possible deadlock in generic_file_write_iter

On Tue, Nov 7, 2017 at 9:11 AM, Peter Zijlstra <peterz@...radead.org> wrote:
> On Tue, Nov 07, 2017 at 09:54:42AM +0900, Byungchul Park wrote:
>> > The best I could come up with is something like the below; its not
>> > at all pretty and I could see people objecting; least of all myself for
>> > the __complete() thing, but I ran out of creative naming juice.
>>
>> Patches assigning a lock_class per gendisk were already applied in tip.
>> I believe that solves this.
>>
>>    e319e1fbd9d42420ab6eec0bfd75eb9ad7ca63b1
>>    block, locking/lockdep: Assign a lock_class per gendisk used for
>>    wait_for_completion()
>>
>> I think the following proposal makes kernel too hacky.
>
> Ah, I tough this was with those included...

Great. Let's tell the bot when to expect this fixed:

#syz fix: block, locking/lockdep: Assign a lock_class per gendisk used
for wait_for_completion()