linux-kernel - Re: [PATCH] dm-crypt, dm-integrity: allow unaligned bv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f8bb8497-7b6d-3ce1-8a59-0eb90975c4c0@gmail.com>
Date:   Tue, 7 Nov 2017 09:31:01 +0100
From:   Milan Broz <gmazyland@...il.com>
To:     Bruno Prémont <bonbons@...ophe.eu>,
        Mikulas Patocka <mpatocka@...hat.com>
Cc:     Mike Snitzer <snitzer@...hat.com>, dm-devel@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dm-crypt, dm-integrity: allow unaligned bv_offset

On 11/07/2017 09:13 AM, Bruno Prémont wrote:
>> Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
>> Cc: stable@...r.kernel.org	# v4.12+
>> Fixes: 8f0009a22517 ("dm crypt: optionally support larger encryption sector size")
>> Fixes: 7eada909bfd7 ("dm: add integrity target")
> 
> Reported-by: Bruno Prémont <bonbons@...ophe.eu>
> Tested-by: Bruno Prémont <bonbons@...ophe.eu>
> 
> Successfully tested on 4.12.14, 4.13.11 and 4.14-rc8+ (e4880bc5dfb1).

Thanks!

(That alignment check was added after our discussion - we wanted
to have dm-crypt and dm-integrity to check the same thing, just to trigger
possible data corruption, but obviously it was incorrect check.)

It must go to stable well, I think there are possibly more situations
we broke for dm-crypt by this.

Reviewed-by: Milan Broz <gmazyland@...il.com>

m.