lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 7 Nov 2017 10:40:04 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>
CC:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] renesas_usbhs: use renesas_usbhs_get_info()

Hi Morimoto-san,

> From: Kuninori Morimoto, Sent: Tuesday, November 7, 2017 5:26 PM
> 
> From: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> 
> We already have renesas_usbhs_get_info() macro.
> Let's use it.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
> ---
> Shimoda-san
> 
> can you please check this patch ?

Thank you for the patch!
If I applied this patch on the latest usb.git of Greg / usb-next branch with
the patch Greg made [1], patch command said:

patching file drivers/usb/renesas_usbhs/common.c
Hunk #1 succeeded at 525 (offset -9 lines).
Hunk #2 succeeded at 703 (offset -9 lines).

I'm not sure you should resolve it or not.
But, this patch could work without any regressions. So,

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>

[1] https://www.spinics.net/lists/linux-usb/msg162421.html

Best regards,
Yoshihiro Shimoda

Powered by blists - more mailing lists