linux-kernel - [PATCH] devcoredump: remove redundant assignment to iter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue,  7 Nov 2017 10:42:15 +0000
From:   Colin King <colin.king@...onical.com>
To:     Johannes Berg <johannes@...solutions.net>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] devcoredump: remove redundant assignment to iter

From: Colin Ian King <colin.king@...onical.com>

The assignment to pointer iter is redundant as this is also performed
in the following macro for_each_sg, hence it can be removed. Cleans
up clang warning:

./include/linux/devcoredump.h:45:2: warning: Value stored to 'iter'
is never read

Signed-off-by: Colin Ian King <colin.king@...onical.com>
---
 include/linux/devcoredump.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/linux/devcoredump.h b/include/linux/devcoredump.h
index 269521f143ac..a9f3e2480739 100644
--- a/include/linux/devcoredump.h
+++ b/include/linux/devcoredump.h
@@ -42,7 +42,6 @@ static inline void _devcd_free_sgtable(struct scatterlist *table)
 	struct scatterlist *delete_iter;
 
 	/* free pages */
-	iter = table;
 	for_each_sg(table, iter, sg_nents(table), i) {
 		page = sg_page(iter);
 		if (page)
-- 
2.14.1