linux-kernel - Re: [Patch v12 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5755591c-7632-f3c8-3dc5-2bb842829f13@arm.com>
Date:   Tue, 7 Nov 2017 10:58:37 +0000
From:   Marc Zyngier <marc.zyngier@....com>
To:     Zhao Qiang <qiang.zhao@....com>, tglx@...utronix.de,
        jason@...edaemon.net
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [Patch v12 1/4] irqchip/qeic: move qeic driver from
 drivers/soc/fsl/qe

On 06/11/17 05:36, Zhao Qiang wrote:
> move the driver from drivers/soc/fsl/qe to drivers/irqchip,
> merge qe_ic.h and qe_ic.c into irq-qeic.c.
> 
> Signed-off-by: Zhao Qiang <qiang.zhao@....com>
> ---
>  MAINTAINERS                                        |   6 ++
>  drivers/irqchip/Makefile                           |   1 +
>  drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} |  95 ++++++++++++++++++-
>  drivers/soc/fsl/qe/Makefile                        |   2 +-
>  drivers/soc/fsl/qe/qe_ic.h                         | 103 ---------------------
>  5 files changed, 100 insertions(+), 107 deletions(-)
>  rename drivers/{soc/fsl/qe/qe_ic.c => irqchip/irq-qeic.c} (85%)
>  delete mode 100644 drivers/soc/fsl/qe/qe_ic.h
In my previous review of the same patch, I asked for the single-bit
constants to be rewritten as BIT(x). You've done none of that. Why?

Thanks,

	M.
-- 
Jazz is not dead. It just smells funny...