linux-kernel - Re: [PATCH] ACPI / PM: fix build regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hY-5Hko3YiW_-kg9Mgaf0qFn+fMUdYyip8ax0ADB6DTA@mail.gmail.com>
Date:   Tue, 7 Nov 2017 12:17:01 +0100
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Paul Menzel <pmenzel@...gen.mpg.de>,
        Stable <stable@...r.kernel.org>, Jean Delvare <jdelvare@...e.de>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ACPI / PM: fix build regression

On Tue, Nov 7, 2017 at 11:48 AM, Arnd Bergmann <arnd@...db.de> wrote:
> The XPS13 workaround caused a build regression in configurations without
> CONFIG_ACPI_SLEEP.
>
> drivers/acpi/sleep.c:95:5: error: redefinition of 'acpi_target_system_state'
>  u32 acpi_target_system_state(void)
>      ^~~~~~~~~~~~~~~~~~~~~~~~
> In file included from include/linux/acpi.h:44:0,
>                  from drivers/acpi/sleep.c:20:
> include/acpi/acpi_bus.h:661:19: note: previous definition of 'acpi_target_system_state' was here
>  static inline u32 acpi_target_system_state(void) { return ACPI_STATE_S0; }
>                    ^~~~~~~~~~~~~~~~~~~~~~~~
> drivers/acpi/sleep.c:495:13: error: 'acpi_pm_end' defined but not used [-Werror=unused-function]
>
> This adds back the #ifdef checks required to make it build cleanly again.
> The patch that caused the regression is marked for backports to v4.13, the
> same should apply to this one.
>
> Fixes: 8d7a4756fef9 ("ACPI / PM: Blacklist Low Power S0 Idle _DSM for Dell XPS13 9360")
> Cc: stable@...r.kernel.org
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

This should have been fixed in my tree already.

Unfortunately, linux-next picked up an earlier version with this issue.

Thanks,
Rafael