linux-kernel - Re: [PATCH 2/2] usbip: use monotonic timestamps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <93e30403-bfe3-9547-122b-bb4955d264be@samsung.com>
Date:   Tue, 07 Nov 2017 12:22:05 +0100
From:   Krzysztof Opasiak <k.opasiak@...sung.com>
To:     Arnd Bergmann <arnd@...db.de>,
        Valentina Manea <valentina.manea.m@...il.com>,
        Shuah Khan <shuah@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     Johan Hovold <johan@...nel.org>,
        Felipe Balbi <felipe.balbi@...ux.intel.com>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] usbip: use monotonic timestamps



On 11/07/2017 11:39 AM, Arnd Bergmann wrote:
> This gets rid of the deprecated do_gettimeofday() function in usbip.
> The comment above vgadget_get_frame() mentions that it suffers
> from issues with the time jumps due to suspend and settimeofday,
> so I'm changing it to use ktime_get_ts64() to use monotonic times
> that don't have this problem.
> 
> I couldn't tell whether we should use CLOCK_MONOTONIC or
> CLOCK_MONOTONIC_RAW here, the difference being the exact rate
> when correcting for NTP. I picked monotonic time since it doesn't
> change the speed to the existing code and should be better
> synchronized with other machines we talk to.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Looks good to me:
Reviewed-by: Krzysztof Opasiak <k.opasiak@...sung.com>

-- 
Krzysztof Opasiak
Samsung R&D Institute Poland
Samsung Electronics