linux-kernel - Re: [PATCH v2 01/31] coccinelle: Improve setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAK7LNARxWAnuMQ_G_AK1=DWKUTw6qkh8QSqyqDwFrkzjEJQNNQ@mail.gmail.com>
Date:   Tue, 7 Nov 2017 09:18:31 +0900
From:   Masahiro Yamada <yamada.masahiro@...ionext.com>
To:     Julia Lawall <julia.lawall@...6.fr>
Cc:     Kees Cook <keescook@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <mmarek@...e.com>, cocci@...teme.lip6.fr,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 01/31] coccinelle: Improve setup_timer.cocci matching

2017-09-24 5:43 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
>
>
> On Wed, 20 Sep 2017, Kees Cook wrote:
>
>> This improves the patch mode of setup_timer.cocci. Several patterns
>> were missing:
>>  - assignments-before-init_timer() cases
>>  - limit the .data case removal to the specific struct timer_list instance
>>  - handling calls by dereference (timer->field vs timer.field)
>>
>> Cc: Julia Lawall <Julia.Lawall@...6.fr>
>> Cc: Gilles Muller <Gilles.Muller@...6.fr>
>> Cc: Nicolas Palix <nicolas.palix@...g.fr>
>> Cc: Michal Marek <mmarek@...e.com>
>> Cc: cocci@...teme.lip6.fr
>> Signed-off-by: Kees Cook <keescook@...omium.org>
>
> Acked-by: Julia Lawall <julia.lawall@...6.fr>
>
> Note that I proposed some changes on this rule as well, on August 23
> (https://systeme.lip6.fr/pipermail/cocci/2017-August/004386.html).  My
> changes are still orthogonal to the ones proposed here.
>
> Actually, my changes are in the part about matching, and this patch on
> covers the -D patch case (transformation).  The matching rules should be
> extended in the same way that the patch rules are extended below, but it
> would be better to apply my patch first.
>
> julia
>

Applied to linux-kbuild/misc


-- 
Best Regards
Masahiro Yamada