linux-kernel - NAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1721c589-d8db-7c45-dc4a-bd77122d1ece@canonical.com>
Date:   Tue, 7 Nov 2017 14:32:14 +0000
From:   Colin Ian King <colin.king@...onical.com>
To:     Daniel Mack <daniel@...que.org>,
        Haojian Zhuang <haojian.zhuang@...il.com>,
        Robert Jarzmik <robert.jarzmik@...e.fr>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: NAK: [PATCH] usb: gadget: pxa27x: Remove redundant assignment to
 is_short

On 07/11/17 14:31, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> Variable is set to zero but this value is never read as it is
> overwritten with a new value later on, hence it is a redundant
> assignment and can be removed. Cleans up clang warning:
> 
> drivers/usb/gadget/udc/pxa27x_udc.c:1141:2: warning: Value stored
> to 'dev' is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>  drivers/usb/gadget/udc/pxa27x_udc.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c
> index 14606f340325..e3d362cc47db 100644
> --- a/drivers/usb/gadget/udc/pxa27x_udc.c
> +++ b/drivers/usb/gadget/udc/pxa27x_udc.c
> @@ -984,8 +984,6 @@ static int write_fifo(struct pxa_ep *ep, struct pxa27x_request *req)
>  
>  	max = ep->fifo_size;
>  	do {
> -		is_short = 0;
> -
>  		udccsr = udc_ep_readl(ep, UDCCSR);
>  		if (udccsr & UDCCSR_PC) {
>  			ep_vdbg(ep, "Clearing Transmit Complete, udccsr=%x\n",
> 
Ignore this, sorry. It's wrong