linux-kernel - Re: [PATCH 1/1] [RFC] blk-mq: fix queue stalling on shared hctx restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 7 Nov 2017 15:54:35 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "roman.penyaev@...fitbricks.com" <roman.penyaev@...fitbricks.com>
CC:     Bart Van Assche <Bart.VanAssche@....com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "hare@...e.com" <hare@...e.com>, "axboe@...com" <axboe@...com>,
        "hch@....de" <hch@....de>
Subject: Re: [PATCH 1/1] [RFC] blk-mq: fix queue stalling on shared hctx
 restart

On Wed, 2017-10-18 at 12:22 +0200, Roman Pen wrote:
> the patch below fixes queue stalling when shared hctx marked for restart
> (BLK_MQ_S_SCHED_RESTART bit) but q->shared_hctx_restart stays zero.

Since I have been able to reproduce this queue stall with an upstream driver
(ib_srp) and since I also have been able to verify that this patch fixes that
stall:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>
Tested-by: Bart Van Assche <bart.vanassche@....com>