linux-kernel - Re: [cdrom_check_status] BUG: unable to handle kernel NULL pointer dereference at 000001c0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxBEMsrqTPOST18iQ_VwNkFxqWq744W74M+8VVT2eL-3w@mail.gmail.com>
Date:   Tue, 7 Nov 2017 08:01:10 -0800
From:   Linus Torvalds <torvalds@...ux-foundation.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Fengguang Wu <fengguang.wu@...el.com>,
        IDE-ML <linux-ide@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        Jens Axboe <axboe@...nel.dk>,
        Bart Van Assche <bart.vanassche@...disk.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [cdrom_check_status] BUG: unable to handle kernel NULL pointer
 dereference at 000001c0

On Tue, Nov 7, 2017 at 6:01 AM, Borislav Petkov <bp@...en8.de> wrote:
>
> Alternatively, we could brown-paper bag it with something like this:

This looks like a good thing to do regardless..

Because this is not really worth spending a ton of effort on debugging
(.. because IDE), but yes, the disassembly of the code clearly shows
that the problem here is that 'info' is NULL.

So adding the NULL guard and saying "we have a race somewhere in the
IDE layer" and not wasting any more time on it is almost certainly the
right thing to do.

Borislav, mind sending a signed-off patch or a pull request or whatever?

             Linus