linux-kernel - Re: [PATCH] [net-next?] of: add of_property_read_variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20171108.133602.1192972972086140265.davem@davemloft.net>
Date:   Wed, 08 Nov 2017 13:36:02 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     arnd@...db.de
Cc:     vivien.didelot@...oirfairelinux.com, robh+dt@...nel.org,
        frowand.list@...il.com, netdev@...r.kernel.org,
        sakari.ailus@...ux.intel.com, grant.likely@...retlab.ca,
        rafael.j.wysocki@...el.com, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] [net-next?] of: add of_property_read_variable_* dummy
 helpers

From: Arnd Bergmann <arnd@...db.de>
Date: Mon,  6 Nov 2017 14:26:10 +0100

> Commit a67e9472da42 ("of: Add array read functions with min/max size
> limits") added a new interface for reading variable-length arrays from
> DT properties. One user was added in dsa recently and this causes a
> build error because that code can be built with CONFIG_OF disabled:
> 
> net/dsa/dsa2.c: In function 'dsa_switch_parse_member_of':
> net/dsa/dsa2.c:678:7: error: implicit declaration of function 'of_property_read_variable_u32_array'; did you mean 'of_property_read_u32_array'? [-Werror=implicit-function-declaration]
> 
> This adds a dummy functions for of_property_read_variable_u32_array()
> and a few others that had been missing here. I decided to move
> of_property_read_string() and of_property_read_string_helper() in the
> process to make it easier to compare the two sets of function prototypes
> to make sure they match.
> 
> Fixes: 975e6e32215e ("net: dsa: rework switch parsing")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks Arnd.