linux-kernel - Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel lockdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171108061551.GD7859@linaro.org>
Date:   Wed, 8 Nov 2017 15:15:54 +0900
From:   "AKASHI, Takahiro" <takahiro.akashi@...aro.org>
To:     "Luis R. Rodriguez" <mcgrof@...nel.org>
Cc:     Mimi Zohar <zohar@...ux.vnet.ibm.com>,
        David Howells <dhowells@...hat.com>,
        linux-security-module@...r.kernel.org, gnomes@...rguk.ukuu.org.uk,
        linux-efi <linux-efi@...r.kernel.org>,
        gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        Matthew Garrett <mjg59@...gle.com>
Subject: Re: Firmware signing -- Re: [PATCH 00/27] security, efi: Add kernel
 lockdown

Luis,

Thank you for this heads-up.

On Wed, Nov 08, 2017 at 12:07:00AM +0100, Luis R. Rodriguez wrote:
> On Thu, Nov 02, 2017 at 06:10:41PM -0400, Mimi Zohar wrote:
> > On Thu, 2017-11-02 at 22:04 +0000, David Howells wrote:
> > > Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> > > 
> > > > > Only validly signed device firmware may be loaded.
> > > > 
> > > > fw_get_filesystem_firmware() calls kernel_read_file_from_path() to
> > > > read the firmware, which calls into the security hooks. Is there
> > > > another place that validates the firmware signatures.  I'm not seeing
> > > > which patch requires firmware to be signed?
> > > 
> > > Luis has a set of patches for this.  However, I'm not sure if that's going
> > > anywhere at the moment.  Possibly I should remove this from the manpage for
> > > the moment.
> 
> Remove it for now. The state of of affairs for firmware signing is complex given
> that we first wanted to address how to properly grow the API without making
> the API worse. This in and of itself was an effort, and that effort also
> evaluated two different development paradigms:
> 
> 	o functional API
> 	o data driven API
> 
> I only recently was convinced that functional API should be used, even for
> commonly used exported symbols,

Are you?
I haven't answered Linus' question, but my concern about functional APIs,
as far as firmware signing goes, is that we have no way to _enforce_
firmware signing to existing (i.e. verification-unaware) drivers if we need
an explicit call of a function, say, verify_firmware().

> and as such I've been going back and slowly
> grooming the firmware API with small atomic changes to first clean up the
> complex flag mess we have.
> 
> Since I'm busy with that Takahiro AKASHI has taken up firmware singing effort
> but this will depend on the above small cleanup to be done first. I was busy
> with addressing existing bugs on the firmware API for a while, then company
> travel / conferences so was not able to address this, but I'm back now and
> I believe I should be able to tackle the cleanup now.

Good to hear.

> Only after this is merged can we expect a final respin of the firmware signing
> effort.
> 
> > Or reflect that IMA-appraisal, if enabled, will enforce firmware being
> > validly signed.
> 
> But FWICT lockdown is a built-in kernel thingy, unless lockdown implies IMA
> it would not be the place to refer to it.

I think that the situation is the same as in module signing.

-Takahiro AKASHI

> It seems the documentation was proposed to help users if an error was caught.
> That error should cover only what is being addressed in code on the kernel.
> 
>   Luis