linux-kernel - Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171108074858.ompog5in7xi776d6@flea.lan>
Date:   Wed, 8 Nov 2017 08:48:58 +0100
From:   Maxime Ripard <maxime.ripard@...e-electrons.com>
To:     Chen-Yu Tsai <wens@...e.org>
Cc:     Corentin Labbe <clabbe.montjoie@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Russell King <linux@...linux.org.uk>,
        devicetree <devicetree@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ARM: sun8i: a83t: add dwmac-sun8i ethernet driver

On Wed, Nov 08, 2017 at 02:27:21PM +0800, Chen-Yu Tsai wrote:
> On Wed, Nov 8, 2017 at 4:13 AM, Corentin Labbe
> <clabbe.montjoie@...il.com> wrote:
> > The dwmac-sun8i is an ethernet MAC hardware that support 10/100/1000 speed.
> > This patch enable the dwmac-sun8i on the Allwinner a83t SoC Device-tree.
> 
> The subject should say "add .... device node", not driver.
> 
> >
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> > Reviewed-by: Chen-Yu Tsai <wens@...e.org>
> > ---
> >  arch/arm/boot/dts/sun8i-a83t.dtsi | 29 +++++++++++++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/sun8i-a83t.dtsi b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > index 19acae1b4089..68e5135410ec 100644
> > --- a/arch/arm/boot/dts/sun8i-a83t.dtsi
> > +++ b/arch/arm/boot/dts/sun8i-a83t.dtsi
> > @@ -336,6 +336,14 @@
> >                         #interrupt-cells = <3>;
> >                         #gpio-cells = <3>;
> >
> > +                       emac_rgmii_pins: emac-rgmii-pins {
> > +                               pins = "PD2", "PD3", "PD4", "PD5", "PD6", "PD7",
> > +                                      "PD11", "PD12", "PD13", "PD14", "PD18",
> > +                                      "PD19", "PD21", "PD22", "PD23";
> > +                               function = "gmac";
> > +                               drive-strength = <40>;
> > +                       };
> > +
> 
> You should mention this change in your commit log.

And add a comment about why that drive strength is needed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Download attachment "signature.asc" of type "application/pgp-signature" (802 bytes)