linux-kernel - Re: [PATCH v7 1/6] x86/tsc: remove tsc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2017 16:52:34 +0800
From:   Dou Liyang <douly.fnst@...fujitsu.com>
To:     Pavel Tatashin <pasha.tatashin@...cle.com>
CC:     Steve Sistare <steven.sistare@...cle.com>,
        Daniel Jordan <daniel.m.jordan@...cle.com>,
        <linux@...linux.org.uk>, <schwidefsky@...ibm.com>,
        <heiko.carstens@...ibm.com>, John Stultz <john.stultz@...aro.org>,
        <sboyd@...eaurora.org>, <x86@...nel.org>,
        <linux-kernel@...r.kernel.org>, <mingo@...hat.com>,
        Thomas Gleixner <tglx@...utronix.de>, <hpa@...or.com>
Subject: Re: [PATCH v7 1/6] x86/tsc: remove tsc_disabled flag

Hi Pavel,

At 11/03/2017 10:23 PM, Pavel Tatashin wrote:
> Hi Dou,
>
> Sure, I can remove the warning, but I think we should print something
> that is indicating that notsc is not a good parameter anymore: i.e
> tsc=unstable is better. Perhaps something like:
> "Kernel parameter \'notsc\'  is deprecated, please use
> \'tsc=unstable\' instead" ?
>

IMO, we already have a message by

mark_tsc_unstable("boot parameter notsc");

and we will use 'notsc' in case of CONFIG_X86_TSC = no

So, I guess there is no need to print this msg.

Thanks,
	dou.

> Pasha