linux-kernel - [PATCH v2] nvme: fix eui

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1510135144-1557-2-git-send-email-javier@cnexlabs.com>
Date:   Wed,  8 Nov 2017 10:59:04 +0100
From:   "Javier González" <jg@...htnvm.io>
To:     hch@....de, sagi@...mberg.me, keith.busch@...el.com,
        joe@...ches.com
Cc:     linux-nvme@...ts.infradead.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Javier González <jg@...htnvm.io>,
        Javier González <javier@...xlabs.com>
Subject: [PATCH v2] nvme: fix eui_show() print format

From: Javier González <jg@...htnvm.io>

Fix print formatting, but keep the original output to prevent user
breakage as suggested by Joe Perches.

Change since v1:
  - Maintain the original output format printing spaces instead of dashes

Signed-off-by: Javier González <javier@...xlabs.com>
Reviewed-by: Keith Busch <keith.busch@...el.com>
---
 drivers/nvme/host/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
index b3bc9fb39a6c..6c9d313c6f90 100644
--- a/drivers/nvme/host/core.c
+++ b/drivers/nvme/host/core.c
@@ -2109,7 +2109,7 @@ static ssize_t eui_show(struct device *dev, struct device_attribute *attr,
 								char *buf)
 {
 	struct nvme_ns *ns = nvme_get_ns_from_dev(dev);
-	return sprintf(buf, "%8phd\n", ns->eui);
+	return sprintf(buf, "%8ph\n", ns->eui);
 }
 static DEVICE_ATTR(eui, S_IRUGO, eui_show, NULL);
 
-- 
2.7.4