linux-kernel - Re: [PATCH] x86/oprofile/ppro: Do not use __this

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711081147310.1937@nanos>
Date:   Wed, 8 Nov 2017 11:48:28 +0100 (CET)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Borislav Petkov <bp@...e.de>
cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Fengguang Wu <fengguang.wu@...el.com>,
        "oprofile-list@...ts.sf.net" <oprofile-list@...ts.sf.net>,
        Robert Richter <rric@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        the arch/x86 maintainers <x86@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86/oprofile/ppro: Do not use __this_cpu* accessors in
 preemptible context

On Tue, 7 Nov 2017, Borislav Petkov wrote:
> --- a/arch/x86/oprofile/op_model_ppro.c
> +++ b/arch/x86/oprofile/op_model_ppro.c
> @@ -212,8 +212,9 @@ static void arch_perfmon_setup_counters(void)
>  	eax.full = cpuid_eax(0xa);
>  
>  	/* Workaround for BIOS bugs in 6/15. Taken from perfmon2 */
> -	if (eax.split.version_id == 0 && __this_cpu_read(cpu_info.x86) == 6 &&
> -		__this_cpu_read(cpu_info.x86_model) == 15) {
> +	if (eax.split.version_id == 0 &&
> +	    boot_cpu_data.x86 == 6 &&
> +	    boot_cpu_data.x86_model == 15) {
>  		eax.split.version_id = 2;
>  		eax.split.num_counters = 2;
>  		eax.split.bit_width = 40;

AFAICT, ppro_setup_ctrs() has the same issue