linux-kernel - Re: [PATCH V2] acpi: apei: call into AER handling regardless of severity

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20171108105915.teb4bgvkyndson5l@pd.tnic>
Date:   Wed, 8 Nov 2017 11:59:15 +0100
From:   Borislav Petkov <bp@...e.de>
To:     Tyler Baicar <tbaicar@...eaurora.org>
Cc:     rjw@...ysocki.net, lenb@...nel.org, will.deacon@....com,
        james.morse@....com, prarit@...hat.com, punit.agrawal@....com,
        shiju.jose@...wei.com, andriy.shevchenko@...ux.intel.com,
        linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] acpi: apei: call into AER handling regardless of
 severity

On Tue, Nov 07, 2017 at 06:21:31PM -0500, Tyler Baicar wrote:
> Do you think this patch is good now?

Yes, it looks ok to me but please split it in two patches:

1. Only code movement without any functional changes
2. Make the change to severity checking and add the comment.

This will make the git history clean and understandable.

Thx.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
--