linux-kernel - Re: [PATCH] staging: comedi: usbdux: remove redundant initialization of val

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0d7da92b-bcf7-2e1e-af62-cf715327e2ed@mev.co.uk>
Date:   Wed, 8 Nov 2017 11:04:18 +0000
From:   Ian Abbott <abbotti@....co.uk>
To:     Colin King <colin.king@...onical.com>,
        H Hartley Sweeten <hsweeten@...ionengravers.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        devel@...verdev.osuosl.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: comedi: usbdux: remove redundant initialization
 of val

On 07/11/17 19:07, Colin King wrote:
> From: Colin Ian King <colin.king@...onical.com>
> 
> The early initialization of val is redundant as the value is never
> read and is updated inside a for-loop. Remove the initialization
> and move the declaration and initialization to the for-loop scope.
> Cleans up clang warning:
> 
> drivers/staging/comedi/drivers/usbdux.c:812:15: warning: Value stored
> to 'val' during its initialization is never read
> 
> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> ---
>   drivers/staging/comedi/drivers/usbdux.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/comedi/drivers/usbdux.c b/drivers/staging/comedi/drivers/usbdux.c
> index f4f05d29d30d..ede064b47aac 100644
> --- a/drivers/staging/comedi/drivers/usbdux.c
> +++ b/drivers/staging/comedi/drivers/usbdux.c
> @@ -809,7 +809,6 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   {
>   	struct usbdux_private *devpriv = dev->private;
>   	unsigned int chan = CR_CHAN(insn->chanspec);
> -	unsigned int val = s->readback[chan];
>   	__le16 *p = (__le16 *)&devpriv->dux_commands[2];
>   	int ret = -EBUSY;
>   	int i;
> @@ -825,7 +824,7 @@ static int usbdux_ao_insn_write(struct comedi_device *dev,
>   	devpriv->dux_commands[4] = chan << 6;
>   
>   	for (i = 0; i < insn->n; i++) {
> -		val = data[i];
> +		unsigned int val = data[i];
>   
>   		/* one 16 bit value */
>   		*p = cpu_to_le16(val);
> 

Thanks for catching that.  It looks like it has been redundant since 
commit 65a847477f63 ("staging: comedi: usbdux: use comedi_subdevice 
'readback'").

Reviewed-by: Ian Abbott <abbotti@....co.uk>

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk> )=-
-=(                          Web: http://www.mev.co.uk/  )=-