linux-kernel - Re: [tip:sched/core] sched/core: Optimize sched_feat() for !SCHED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20171108112450.GB31247@e110439-lin>
Date:   Wed, 8 Nov 2017 11:24:50 +0000
From:   Patrick Bellasi <patrick.bellasi@....com>
To:     Ingo Molnar <mingo@...nel.org>
Cc:     hpa@...or.com, vincent.guittot@...aro.org, juri.lelli@...hat.com,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        morten.rasmussen@....com, dietmar.eggemann@....com,
        peterz@...radead.org, brendan.jackman@....com,
        torvalds@...ux-foundation.org, chris.redpath@....com,
        linux-tip-commits@...r.kernel.org
Subject: Re: [tip:sched/core] sched/core: Optimize sched_feat() for
 !SCHED_DEBUG builds

On 08-Nov 11:02, Patrick Bellasi wrote:
> On 08-Nov 11:03, Ingo Molnar wrote:
> > 
> > * tip-bot for Patrick Bellasi <tipbot@...or.com> wrote:
> > 
> > > Commit-ID:  692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Gitweb:     https://git.kernel.org/tip/692ee9a79c14c9f707eeb03754a26b9427c0e005
> > > Author:     Patrick Bellasi <patrick.bellasi@....com>
> > > AuthorDate: Tue, 7 Nov 2017 16:06:58 +0000
> > > Committer:  Ingo Molnar <mingo@...nel.org>
> > > CommitDate: Wed, 8 Nov 2017 10:17:29 +0100
> > > 
> > > sched/core: Optimize sched_feat() for !SCHED_DEBUG builds
> > 
> > Hm, I noticed this too late, but lots of architecture defconfig builds now produce 
> > a ton of warnings:
> > 
> >  In file included from /home/mingo/tip/kernel/sched/idle.c:19:0:
> >  /home/mingo/tip/kernel/sched/sched.h:1275:33: warning: 'sysctl_sched_features' defined but not used [-Wunused-variable]
> >   static const_debug unsigned int sysctl_sched_features =
> >                                   ^

Perhaps just using a "__maybe_unused" attribute should fix the problem.

Going to compile test with some more archs, can you tell me a
defconfig failing for you?

> > I'm dropping this patch for now.
> 
> Ok Ingo, thanks.
> Actually, my fault  I did not checked archs other then arm64 and x86_64.
> I'll look into this and respin a clean new version.
> 
> > Thanks,
> > 
> > 	Ingo
> 
> Cheers Patrick
> 
> -- 
> #include <best/regards.h>
> 
> Patrick Bellasi

-- 
#include <best/regards.h>

Patrick Bellasi