linux-kernel - Re: [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into a separate function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 08 Nov 2017 10:25:13 +0900 (KST)
From:   David Miller <davem@...emloft.net>
To:     mail@...iej.szmigiero.name
Cc:     andrew@...n.ch, f.fainelli@...il.com, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] net: phy: leds: Refactor "no link" handler into
 a separate function

From: "Maciej S. Szmigiero" <mail@...iej.szmigiero.name>
Date: Thu, 2 Nov 2017 00:48:45 +0100

> Currently, phy_led_trigger_change_speed() is handling a "no link" condition
> like it was some kind of an error (using "goto" to a code at the function
> end).
> 
> However, having no link at PHY is an ordinary operational state, so let's
> handle it in an appropriately named separate function so it is more obvious
> what the code is doing.
> 
> Signed-off-by: Maciej S. Szmigiero <mail@...iej.szmigiero.name>

Applied.