linux-kernel - Re: [PATCH] Coccinelle: use false positive annotation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.20.1711082102560.2708@hadrien>
Date:   Wed, 8 Nov 2017 21:03:09 +0800 (CST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
cc:     Julia Lawall <julia.lawall@...6.fr>,
        Fengguang Wu <fengguang.wu@...el.com>,
        "Rafael J . Wysocki" <rjw@...ysocki.net>,
        kernel-janitors@...r.kernel.org,
        Gilles Muller <Gilles.Muller@...6.fr>,
        Nicolas Palix <nicolas.palix@...g.fr>,
        Michal Marek <michal.lkml@...kovi.net>, cocci@...teme.lip6.fr,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Coccinelle: use false positive annotation



On Tue, 7 Nov 2017, Masahiro Yamada wrote:

> 2017-10-30 12:52 GMT+09:00 Julia Lawall <julia.lawall@...6.fr>:
> >
> >
> > On Mon, 30 Oct 2017, Masahiro Yamada wrote:
> >
> >> Hi Julia,
> >>
> >>
> >> 2017-10-29 8:43 GMT+09:00 Julia Lawall <Julia.Lawall@...6.fr>:
> >> > /// is to describe the semantic patch, while //# indicates reasons
> >> > for false positives.
> >> >
> >> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> >> >
> >> > ---
> >> >  scripts/coccinelle/misc/ifcol.cocci |    6 +++---
> >> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >> >
> >> > diff --git a/scripts/coccinelle/misc/ifcol.cocci b/scripts/coccinelle/misc/ifcol.cocci
> >> > index d0d00ef..30b248b 100644
> >> > --- a/scripts/coccinelle/misc/ifcol.cocci
> >> > +++ b/scripts/coccinelle/misc/ifcol.cocci
> >> > @@ -3,9 +3,9 @@
> >> >  /// Sometimes, code after an if that is indented is actually intended to be
> >> >  /// part of the if branch.
> >> >  ///
> >> > -/// This has a high rate of false positives, because Coccinelle's column
> >> > -/// calculation does not distinguish between spaces and tabs, so code that
> >> > -/// is not visually aligned may be considered to be in the same column.
> >> > +//# This has a high rate of false positives, because Coccinelle's column
> >> > +//# calculation does not distinguish between spaces and tabs, so code that
> >> > +//# is not visually aligned may be considered to be in the same column.
> >> >  ///
> >>
> >> Just a nit.
> >>
> >> The last /// should be turned into //
> >> if you want to avoid two blank lines in a series
> >> after the semantic patch information.
> >>
> >> (I can fix it locally if you agree with it and I am supposed to pick up this.)
> >
> > Thanks for detecting the problem.  It would be great if you could pick it
> > up, since I haven't heard confirmation from Michal that he will start this
> > again.  The change seems fine.  Thanks for your help.
> >
> > julia
> >
> >>
>
> Fix up the second ///
> and applied to linux-kbuild/misc.

Thanks!

julia