linux-kernel - Re: [PATCH] lost path_put in perf_fill_ns_link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 8 Nov 2017 16:04:47 +0300
From:   Vasily Averin <vvs@...tuozzo.com>
To:     Alexander Shishkin <alexander.shishkin@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org,
        Hari Bathini <hbathini@...ux.vnet.ibm.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Jiri Olsa <jolsa@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ingo Molnar <mingo@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] lost path_put in perf_fill_ns_link_info

On 2017-11-08 15:09, Alexander Shishkin wrote:
> On Mon, Nov 06, 2017 at 09:22:18AM +0300, Vasily Averin wrote:
>> Fixes: commit e422267322cd ("perf: Add PERF_RECORD_NAMESPACES to include namespaces related info")
>> Signed-off-by: Vasily Averin <vvs@...tuozzo.com>
> 
> The change description is missing. One needs to open the source code and
> look for proof of correctness for this patch.

perf_fill_ns_link_info() calls ns_get_path()
it returns ns_path with increased mnt and dentry counters.

Problem is that nodody decrement these counters.

You can call ./perf record --namespaces unshare -m
and look how grows mount counter on nsfs_mnt.