linux-kernel - Re: [PATCH] s390/dasd: avoid calling do

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a3tLNE1rMgJS1vEeTZEPQxrO7B5dbK6QOrdX7uYq+su9w@mail.gmail.com>
Date:   Wed, 8 Nov 2017 14:56:23 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Stefan Haberland <sth@...ux.vnet.ibm.com>
Cc:     Jan Hoeppner <hoeppner@...ux.vnet.ibm.com>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-s390 <linux-s390@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] s390/dasd: avoid calling do_gettimeofday()

On Wed, Nov 8, 2017 at 2:27 PM, Stefan Haberland <sth@...ux.vnet.ibm.com> wrote:
> On 06.11.2017 15:02, Arnd Bergmann wrote:
>> diff --git a/drivers/s390/block/dasd_eer.c b/drivers/s390/block/dasd_eer.c
>> index 4630782b5456..5169c717c9d6 100644
>> --- a/drivers/s390/block/dasd_eer.c
>> +++ b/drivers/s390/block/dasd_eer.c
>> @@ -296,7 +296,7 @@ static void dasd_eer_write_standard_trigger(struct
>> dasd_device *device,
>>   {
>>         struct dasd_ccw_req *temp_cqr;
>>         int data_size;
>> -       struct timeval tv;
>> +       struct timespec64 ts64;
>
> ...
>>
>> +       ktime_get_real_ts64(&ts);
>> +       header.tv_sec = ts.tv_sec;
>> +       header.tv_usec = ts.tv_nsec / NSEC_PER_USEC;
>>
>
> I renamed ts64 to ts to match the usage below and fix the compile error.
>
> Beside of this, applied. Thanks for the patch.
>

Thanks and sorry for not build-testing it properly, I thought I had at
least compiled
this one separately with my cross-toolchain, but maybe I renamed the variable
after testing it, or I misremember testing it.

        Arnd