linux-kernel - Re: [PATCH 1/2] ASoC: Intel: improve DMADEVICES dependency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a083zZnN1rZOV6Ox_pR24YJf9MCZiNV4KmpuTiMV_F8eA@mail.gmail.com>
Date:   Wed, 8 Nov 2017 15:10:18 +0100
From:   Arnd Bergmann <arnd@...db.de>
To:     Vinod Koul <vinod.koul@...el.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Harsha Priya N <harshapriya.n@...el.com>,
        Daniel Drake <drake@...lessm.com>,
        Naveen M <naveen.m@...el.com>, alsa-devel@...a-project.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/2] ASoC: Intel: improve DMADEVICES dependency

On Wed, Nov 8, 2017 at 3:09 PM, Vinod Koul <vinod.koul@...el.com> wrote:
> On Wed, Nov 08, 2017 at 02:03:19PM +0100, Arnd Bergmann wrote:
>> As pointed out by Pierre-Louis Bossart, the depndency I added
>
> /s/depndency/dependency

Mark, can you fix that up when applying, or should I resend?

>> diff --git a/sound/soc/intel/Kconfig b/sound/soc/intel/Kconfig
>> index e18118209b75..bb8be10b8437 100644
>> --- a/sound/soc/intel/Kconfig
>> +++ b/sound/soc/intel/Kconfig
>> @@ -32,19 +32,20 @@ config SND_SOC_ACPI_INTEL_MATCH
>>  config SND_SOC_INTEL_SST_TOPLEVEL
>>       tristate "Intel ASoC SST drivers"
>>       depends on X86 || COMPILE_TEST
>> -     depends on DMADEVICES
>>       select SND_SOC_INTEL_MACH
>>       select SND_SOC_INTEL_COMMON
>>
>>  config SND_SOC_INTEL_HASWELL
>>       tristate "Intel ASoC SST driver for Haswell/Broadwell"
>>       depends on SND_SOC_INTEL_SST_TOPLEVEL && SND_DMA_SGBUF
>> +     depends on DMADEVICES
>>       select SND_SOC_INTEL_SST
>>       select SND_SOC_INTEL_SST_FIRMWARE
>>

>> --- a/sound/soc/intel/boards/Kconfig
>> +++ b/sound/soc/intel/boards/Kconfig
>> @@ -19,7 +19,6 @@ config SND_SOC_INTEL_HASWELL_MACH
>>       tristate "ASoC Audio DSP support for Intel Haswell Lynxpoint"
>>       depends on SND_SOC_INTEL_MACH
>>       depends on X86_INTEL_LPSS && I2C && I2C_DESIGNWARE_PLATFORM
>> -     depends on DMADEVICES
>
> Per Liam this seems to be required for Haswell
>
>
>>       depends on SND_SOC_INTEL_HASWELL

Correct, I just moved it to a different place above, we now get it through
the SND_SOC_INTEL_HASWELL dependency.

      Arnd