linux-kernel - Re: [PATCH] selftests: kselftest.h: fix compilation errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ac0008c-df35-6df3-03c9-5698815d18b2@osg.samsung.com>
Date:   Wed, 8 Nov 2017 08:26:16 -0700
From:   Shuah Khan <shuahkh@....samsung.com>
To:     Lei Yang <Lei.Yang@...driver.com>, linux-kselftest@...r.kernel.org,
        linux-kernel@...r.kernel.org, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests: kselftest.h: fix compilation errors

On 11/07/2017 10:24 PM, Lei Yang wrote:
> In next branch, Various build failed with:
> 
> In file included from membarrier_test.c:8:0:
> ../kselftest.h: In function ‘ksft_print_header’:
> ../kselftest.h:61:3: error: expected ‘)’ before ‘printf’
>    printf("TAP version 13\n");
>    ^
> ../kselftest.h:62:1: error: expected expression before ‘}’ token
>  }
>  ^
> 
> Signed-off-by: Lei Yang <Lei.Yang@...driver.com>
> ---
>  tools/testing/selftests/kselftest.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/kselftest.h b/tools/testing/selftests/kselftest.h
> index d6732ba312ef..acc98a5c3d73 100644
> --- a/tools/testing/selftests/kselftest.h
> +++ b/tools/testing/selftests/kselftest.h
> @@ -57,7 +57,7 @@ static inline int ksft_get_error_cnt(void) { return ksft_cnt.ksft_error; }
>  
>  static inline void ksft_print_header(void)
>  {
> -	if (!(getenv("KSFT_TAP_LEVEL"))
> +	if (!(getenv("KSFT_TAP_LEVEL")))
>  		printf("TAP version 13\n");
>  }
>  
> 

Thanks for the patch. It was a mistake that the original patch
ended up in the linux-kselftest next branch. My bad. I ended up
committing the patch my mistake. It is now removed.

thanks,
-- Shuah